[bugfix] same SMTP configs usage for different stores #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Fix bugs with the usage of the same transport object (as a result same SMTP configs) for different stores.
Steps to reproduce
Expected results
Emails will be sent with corresponding SMTP configs for each website.
Actual result
First order
is sent correctly.Second order
in a chain will gonna use SMTP configs from website/store of theFirst order
and fail with error:Solution Description
Introduce store-scoped storage for transport object.
The transport object incapsulates connection configs, connection socket itself and persists connection state.
For different stores, with different configs, connection configs and connection sockets should be different.