Skip to content

[bugfix] same SMTP configs usage for different stores #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

vpodorozh
Copy link

Purpose of PR

Fix bugs with the usage of the same transport object (as a result same SMTP configs) for different stores.

Steps to reproduce

  1. Prepare two different websites with different SMTP configs;
  2. Place two orders on different websites;
  3. Execute email sending for those orders in one PHP process.

Expected results

Emails will be sent with corresponding SMTP configs for each website.

Actual result

  • First order is sent correctly.
  • Second order in a chain will gonna use SMTP configs from website/store of the First order and fail with error:
Failed to send email 554 5.2.252 SendAsDenied ***@***.com; not allowed to send as ***@***.com
STOREDRV Submission Exception SendAsDeniedException Map ...

Solution Description

Introduce store-scoped storage for transport object.
The transport object incapsulates connection configs, connection socket itself and persists connection state.
For different stores, with different configs, connection configs and connection sockets should be different.

Fix bugs with the same transport usage for different stores.
[bugfix] same SMTP configs usage for different stores
@vpodorozh
Copy link
Author

Duplicated of #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant